Closed jeanconn closed 4 months ago
@taldcroft You'd mentioned from your review that find_attitude would be fine for operational use with AGASC 1.8 in use but the distances file still built with 1.7. I think that this test failure when AGASC 1.8 was in use on this one test just speaks to a specific use case of doing a matching check that uses the ids in the distances file (in a way we don't for operational use). But not sure what functional testing you had in mind for find_attitude or if you wanted to update the distances file in advance of 1.8 promotion anyway.
After much head scratching, I finally understood that the test is failing due to two nearby stars 1230122672 and 1230121896. They are separated by about half-arcsec and 5.6 and 6.6 mag respectively. The head scratching was because that test failure was not quite reproducible, depending on the seed and other circumstances. What was happening is that sometimes it would get the wrong one of the pair due to the random variation in observed star yag/zag.
Upshot is that this PR should be closed in favor of #30.
Ah. I did not know that the test sometimes passed with 1.8 so assumed it was a 1.7 issue.
Description
Pin a test at 1p7 and set rest for agasc1p8 via rc
Fixes test not passing with agasc 1p8.
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.