search

sot / jobwatch

Watch files, database tables, and log files to ensure valid cron processing
3 stars 0 forks source link

Make into a package #41

Closed jeanconn closed 3 years ago

jeanconn commented 3 years ago

Make into a package

Not sure what testing would be appropriate, but there's a change in here so it at least passes all of its own tests.

jeanconn commented 3 years ago

With regard to testing, I don't quite see the need for a soak period? This doesn't really have different behaviors over time.

taldcroft commented 3 years ago

The soak period will naturally happen between when you start the job going and we are ready with a release. I'd just like to see an end-to-end test for a few days because it is so easy to make a little mistake in packaging (I've done this many times).

jeanconn commented 3 years ago

@taldcroft if you were interested in installing this in the next ska3 update but also running on the side, I think we would have a little bit of a collision issue for data/skawatch3 and www/skawatch3 . Did you want to, say, reclaim skawatch instead of skawatch3?

jeanconn commented 3 years ago

Actually, since we win nothing (no updated checks or fixes in here) by putting this PR in skare3 2021.1, I think we should just hold this one.

jeanconn commented 3 years ago

OK. I think I've addressed the comments and we probably don't care about fixing jobwatch type inheritance or whatever, so merging despite the "changes requested" bit.