Closed jeanconn closed 7 months ago
When you say "max age test" do you mean the new test on cmds going out into the future? I figured that was replacing our previous check on cmds in cmd_states and is more of a check that loads are approved and the process to read and update from APPR_LOADS is working than a check that the events are up to date.
Yes on the first question. My point is just that kadi states validation will catch all of the things that you mentioned because telemetry will no longer match available commands.
In any case I stand by my approval of this as is!
My point was just that validation doesn't go into the future but commands do and that was the point of the check, though right now it would really just mean that we'd get a ska warning on Sunday morning if loads weren't promoted correctly (and maybe that wouldn't be super-helpful). I suppose that actually speaks more to an RFE for load review to check that, generally, kadi cmds cover a range within a day or less of the new loads.
Description
Add kadi events to hourly watch .
It would be slightly nicer if they were labeled 'kadi' in the output but we should be able to figure out it.
Add kadi cmds to daily watch to confirm that the last cmd generally is in the future.
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Run "now" with output to:
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/jobwatch-pr63/status/
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/jobwatch-pr63/2024058/index.html