sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Py3 compatibility fixes #101

Closed taldcroft closed 6 years ago

taldcroft commented 7 years ago

Not clear why it wasn't failing before, but here we go.

jeanconn commented 7 years ago

On flight PY2 I'm still getting the sftp errors when cleaning up, but I still think that needs a fix in Ska.ftp, and I haven't figured out a fix that works for both PY2 and PY3.

ska-fido: py.test
============================= test session starts ==============================
platform linux2 -- Python 2.7.9 -- py-1.4.26 -- pytest-2.6.4
collected 15 items 

kadi/tests/test_events.py ..........
kadi/tests/test_occweb.py .....

========================== 15 passed in 84.01 seconds ==========================
Exception TypeError: 'must be type, not None' in <bound method SFTP.__del__ of <Ska.ftp.ftp.SFTP object at 0x7f052b66e510>> ignored
jeanconn commented 7 years ago

On new ska3/flight, I seem to get two test skips and I haven't figured those out yet.

fido: py.test --verbose
============================= test session starts ==============================
platform linux -- Python 3.6.0, pytest-3.1.2, py-1.4.34, pluggy-0.4.0 -- /proj/sot/ska3/flight/arch/x86_64-linux_CentOS-5/bin/python
cachedir: .cache
rootdir: /proj/sot/ska/jeanproj/git/kadi, inifile:
collected 15 items 

kadi/tests/test_events.py::test_overlapping_intervals PASSED
kadi/tests/test_events.py::test_interval_pads PASSED
kadi/tests/test_events.py::test_query_event_intervals PASSED
kadi/tests/test_events.py::test_basic_query PASSED
kadi/tests/test_events.py::test_zero_length_query PASSED
kadi/tests/test_events.py::test_short_query PASSED
kadi/tests/test_events.py::test_get_obsid PASSED
kadi/tests/test_events.py::test_intervals_filter PASSED
kadi/tests/test_events.py::test_get_overlaps PASSED
kadi/tests/test_events.py::test_select_overlapping PASSED
kadi/tests/test_occweb.py::test_put_get_user_from_netrc SKIPPED
kadi/tests/test_occweb.py::test_put_get_user_none SKIPPED
kadi/tests/test_occweb.py::test_ifot_fetch PASSED
kadi/tests/test_occweb.py::test_get_fdb_major_events PASSED
kadi/tests/test_occweb.py::test_get_fot_major_events PASSED

==================== 13 passed, 2 skipped in 13.30 seconds ===================