sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fix a couple of issues in continuity #109

Closed taldcroft closed 6 years ago

taldcroft commented 6 years ago

@jeanconn - when you have a chance next week please review and (hopefully) merge and install to Ska HEAD flight, test, ska3 flight and GRETA test and ska3.

Ran self tests in ska and ska3 on kadi.

jeanconn commented 6 years ago

I'm getting an exception on one of the occweb tests, but it looks like this is not a regression (is failing with kadi 3.15.2 as well). From some tests I ran in Ska.ftp last week, it looks to me like lucky sftp either throttles logins or times-out pretty frequently. Putting this here in this PR to note that I did run kadi tests and I'm accepting the fail.

kadi/tests/test_occweb.py .F...

=================================== FAILURES ===================================
____________________________ test_put_get_user_none ____________________________

    @pytest.mark.skipif('not HAS_LUCKY')
    def test_put_get_user_none():
        # Test the user=None code branch (gets username back from SFTP object, which
        # had previously gotten it from the netrc file).
>       _test_put_get(user=None)

kadi/tests/test_occweb.py:75: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
kadi/tests/test_occweb.py:51: in _test_put_get
    lucky = Ska.ftp.SFTP('lucky')
Ska.ftp-3.5-py2.7.egg/Ska/ftp/ftp.py:72: in __init__
    transport.connect(username=user, password=passwd)
paramiko/transport.py:978: in connect
    self.start_client()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <paramiko.Transport at 0x6047fa90L (unconnected)>
event = <threading._Event object at 0x7fec6047fd10>

    def start_client(self, event=None):

E                   SSHException: Error reading SSH protocol banner

paramiko/transport.py:406: SSHException
----------------------------- Captured stderr call -----------------------------
No handlers could be found for logger "paramiko.transport"
=============== 1 failed, 41 passed, 1 xfailed in 136.69 seconds ===============
Out[2]: 1