sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Do event updates on a local copy and mv back #124

Closed taldcroft closed 5 years ago

taldcroft commented 5 years ago

@jeanconn - I did some testing locally on the implications of the events.db3 file going missing or changing during an active session.

Testing:

As far as I can tell the file system does the right thing, which is to say that the active process holds on to the file handle and so queries continue working, using a phantom database that only exists in the internal file system but not visible to user.

cc: @linamaria11

jeanconn commented 5 years ago

I don't think it matters, but was your "local" version on local disk or still NFS?

taldcroft commented 5 years ago

NFS, but not /proj/sot/ska. Instead /data/baffin served by numa.

jeanconn commented 5 years ago

Sounds good. I can't imagine that there would be significantly different behaviors for different mounts.

taldcroft commented 5 years ago

It turns out that local testing was not entirely complete as I accidentally had a copy of ltt_bads.dat in the directory, and in a task schedule config one needs to specify /bin/mv, /bin/mkdir etc.

The new version is now installed to /proj/sot/ska/data/kadi and has been shown to work (after fixes). Plan to put in a bug-fix version update (including #121 also) and tag a release, but since affected files are not in the install tarball I think no immediate action is required now except to copy taskschedule* files to GRETA also.

jeanconn commented 5 years ago

Not sure what happened with this, but any reason not to merge and tag?

taldcroft commented 5 years ago

Yes, please merge and tag.