Closed jeanconn closed 2 years ago
These look like issues in the numeric comparisons after the 8th decimal place in pitch (probably didn't need to go out that far?). I'm OK with this not getting fixed for the release if my assessment is accurate (we have tests in Ska.Shell and cmd_states that are also not passing and it would be my hope to fix up broken tests next release).
exp = [' datestart datestop pitch pcad_mode',
'--------------------- --------------------- ------------- ---------',
'2019:039:14:16:25.002 2019:039:14:16:54.364 63.2696565838 NMAN',
'2019:039:14:16:54.364 2019:039:14:22:01.825 83.0388345752 NMAN',
'2019:039:14:22:01.825 2019:039:14:27:09.285 106.057258631 NMAN',
'2019:039:14:27:09.285 2019:039:14:32:16.745 129.079427541 NMAN',
'2019:039:14:32:16.745 2019:039:14:37:24.205 148.857427163 NMAN',
'2019:039:14:37:24.205 2019:039:14:42:31.665 159.541502291 NMAN',
'2019:039:14:42:31.665 2019:039:16:00:00.000 161.950922135 NPNT']
vs
ipdb> sts
<Table length=7>
datestart datestop pitch pcad_mode
str21 str21 float64 str4
--------------------- --------------------- ------------- ---------
2019:039:14:16:25.002 2019:039:14:16:54.364 63.2696565838 NMAN
2019:039:14:16:54.364 2019:039:14:22:01.825 83.0388345748 NMAN <- ends in 48 no 52
2019:039:14:22:01.825 2019:039:14:27:09.285 106.05725863 NMAN <- stops at 3 not 31
2019:039:14:27:09.285 2019:039:14:32:16.745 129.079427541 NMAN
2019:039:14:32:16.745 2019:039:14:37:24.205 148.857427163 NMAN
2019:039:14:37:24.205 2019:039:14:42:31.665 159.541502291 NMAN
2019:039:14:42:31.665 2019:039:16:00:00.000 161.950922135 NPNT
Stupid, my bad, being lazy doesn't really save time.
But more to the point, this is OK.
Thanks! And I can take some "my bad" credit for not stepping up and doing the 32 bit test before we tagged the package.