search

sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fix PEP8 and flake8 and clean Py2-only cruft #140

Closed taldcroft closed 4 years ago

taldcroft commented 4 years ago

About # noqa, that's sort of standard I think we'll get used to the limited situations where it is used (basically import * and the rare instance of line > 100 chars that should be left).

But agreed that the one non-obvious case of the table import by the decorator, that should be commented. I'll do that.

taldcroft commented 4 years ago

Good point on the additional scope of dropping support for Py2. So I added that to the title. That's where we have to be a bit pragmatic. :smile:.

jeanconn commented 4 years ago

Though I thought we dropped Py2 support at some point in the past when this became a version 4.x module; the tables3_api import might have been more Py2 cruft than Py2 support.

javierggt commented 4 years ago

yes, I'm all in for dropping support for py2. Still :)

taldcroft commented 4 years ago

Correct, Py2 support was dropped previously. Title changed again! "Fix PEP8 and flake8 and clean Py2-only cruft"