search

sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Missing .git_archival.txt and .gitattributes #155

Closed taldcroft closed 4 years ago

taldcroft commented 4 years ago

Looks like this one missed getting the new .gitarchival.txt and .gitattributes files. Probably my bad, but this needs to be fixed with a 5.0.1 for the MATLAB release because the zip download won't python setup.py install.

jeanconn commented 4 years ago

Since, if I understand correctly, these are just used on the github side and don't o into the conda packae, I'm not convinced it would be a horrible version control faux pas to retag 5.0...

taldcroft commented 4 years ago

Well I have that tag in at least 2 local repos by now, and I don't know off hand if that will be an issue.

There is nothing preventing ska3-matlab from using 5.0.1 while ska3-flight uses 5.0.0, but in practice there are more changes in the works like https://github.com/sot/proseco/pull/297 that we should get in for a release in both flight and matlab.

taldcroft commented 4 years ago

(Noting that from the Windows build perspective all that really matters right now is the version tag in ska3-matlab).