search

sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fix bug in command-not-run command set and test #222

Closed taldcroft closed 2 years ago

taldcroft commented 2 years ago

Description

There was a problem with the Command not run command set that was missed in testing. It had previously worked when the cmds2.h5 was generated, but a subsequent change broke it, but this was not seen until I regenerated the commands now.

This PR fixes the problem and adds complete testing of all the allowed command sets.

Note: in order for tests to pass this is based off of #221 and the merge request is into that branch.

Interface impacts

None.

Testing

Unit tests

Independent check of unit tests by Javier

Functional tests

No functional testing.

jeanconn commented 2 years ago

Late to party but I did the same review and came to the same conclusion (good to go).