search

sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Make commands v2 the default #249

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

This makes commands v2 the default and thus v1 is now the backup.

Interface impacts

There are API changes that have been widely discussed in informational forums. In particular getting commands may try using network resources by default.

The new version of commands archive files generated with PR #248 should be installed into $SKA/data/kadi on HEAD when kadi commands v2 is promoted via a new ska3-flight release. Those files are in /home/aldcroft/tmp/kadi on HEAD.

Testing

Unit tests

Independent check of unit tests by Jean

Functional tests

No functional testing.

jeanconn commented 1 year ago

Did the docs lose the a breadcrumb to set to v1 with commands.conf.commands_version = "1"?

taldcroft commented 1 year ago

@jeanconn - I rebased to fix the merge conflicts and re-ran unit tests with no failures. I also added a docs file docs/commands_v1.rst which I had previously forgotten to add. This file contains the requested breadcrumbs.