search

sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fix unit test failure for final v2 cmds #254

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

The cmds v2 archive was regenerated using version 7.0.0 with migrate_cmds_to_cmds2.py. Using this new file the unit tests pass (in particular the create_archive one for v2), except for the test that is fixed here.

This change is expected/desired because the observation in question previously had the wrong starcat_date associated with it. This obs was really a ground-commanded maneuver with a custom starcat that is not captured by the commands archive. Leaving the starcat as undefined is the right thing in this case.

Interface impacts

Testing

Make a directory to store kadi archive files. From within that directory:

ln -s /proj/sot/ska/data/kadi/cmds-v7.0.x/cmds2.* ./
ln -s /proj/sot/ska/data/kadi/cmds.* ./
ln -s /proj/sot/ska/data/kadi/events3.db3 ./

export KADI=$PWD

Then run unit tests.

Unit tests

Independent check of unit tests by Jean

Functional tests

No functional testing.