This adds complete_intervals=True to a key call to logical_intervals that defines the creation of kadi events. Previously this was relying on the default value of that kwarg being True. Since that default is being changed in https://github.com/sot/eng_archive/pull/243, here we need to be explicit.
While in the code I noticed that an ugly hack of the @import_ska decorator is no long needed now that the kadi package does not provide a web server. This hack doesn't play well with IDEs (code introspection doesn't work).
Interface impacts
None.
Testing
Unit tests
[x] Mac
Independent check of unit tests by [REVIEWER NAME]
Description
This adds
complete_intervals=Trueto a key call tological_intervalsthat defines the creation of kadi events. Previously this was relying on the default value of that kwarg being True. Since that default is being changed in https://github.com/sot/eng_archive/pull/243, here we need to be explicit.While in the code I noticed that an ugly hack of the
@import_skadecorator is no long needed now that the kadi package does not provide a web server. This hack doesn't play well with IDEs (code introspection doesn't work).Interface impacts
None.
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.