Remove a testing workaround

sot / kadi

Chandra commands and events

https://sot.github.io/kadi

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

Remove a testing workaround #273

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

This is a clean-up item.

Interface impacts

None

Testing

Unit tests

[x] Mac

Independent check of unit tests by Jean

[x] Linux

Functional tests

No functional testing.

jeanconn commented 1 year ago

Since the flight archive has been regenerated, am I correctly understanding that this "Fix" and its removal is a no-op? Because there are no commands to remove it isn't removing them, right?

jeanconn commented 1 year ago

So in conversation, the commands that were "removed" by this fix were appropriate/correct but only existed in "local" not "flight" so the test would fail until regenerating the archive. Now the test fix can be removed and these commands can be checked instead of ignored.