sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Compare regression test quaternions with delta-quat tolerance check #288

Closed jeanconn closed 1 year ago

jeanconn commented 1 year ago

Description

Compare regression test quaternions with delta-quat tolerance check instead of == test.

This fixes the issue that the calculated quaternions on fido present insignificant numeric differences from the same quaternions calculated on kady.

Interface impacts

Testing

Unit tests

Independent check of unit tests by @taldcroft

Functional tests

No functional testing.

jeanconn commented 1 year ago

Yes - that was what I tested before moving this from non-WIP status and asking for review.

jeanconn commented 1 year ago

Honestly, I hadn't run the tests on kady, so I'll leave that as an exercise for integration testing.