search

sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Add validator for sun position monitor #292

Closed taldcroft closed 10 months ago

taldcroft commented 11 months ago

Description

This adds a state validator for the sun_pos_mon state.

It also fixes a bug where telemetry values with a trailing space character (e.g. "ACT ") do not match the state codes.

Interface impacts

Adds a new plot in the state validation page.

Testing

Unit tests

Independent check of unit tests by Jean

Functional tests

From within the git repo:

python -m kadi.scripts.validate_states

This generated the following output: https://icxc.cfa.harvard.edu/aspect/test_review_outputs/kadi-pr292/

jeanconn commented 11 months ago

This looks good to me. I note that in review of the report page I see issues with plotting negatives in the Y axis on some of the other plots which I can open as a separate issue.

taldcroft commented 11 months ago

Thanks. If you are good with this then please approve it.

jeanconn commented 11 months ago

Still running the unit tests.

jeanconn commented 10 months ago

I think this is ready-to-go.