search

sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Use ska_helpers.utils.convert_to_int_float_str to stop Deprecation warns #296

Closed jeanconn closed 8 months ago

jeanconn commented 8 months ago

Use ska_helpers.utils.convert_to_int_float_str directly instead of parse_cm.common._coerce_type .

Description

Stops warnings like

kadi/commands/tests/test_states.py: 1 warning
  /fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/parse_cm/common.py:33: VisibleDeprecationWarning: The _coerce_type function is deprecated and will be removed in a future version of parse_cm. Use ska_helpers.utils.convert_to_int_float_str instead.
    warnings.warn(

Interface impacts

Testing

Tested in ska3-masters with https://github.com/sot/parse_cm/pull/44

Unit tests

Independent check of unit tests by [REVIEWER NAME]

Functional tests

Unit tests with and without this PR show no warning with PR and warning without and otherwise pass.