Closed taldcroft closed 7 months ago
Technically I think this needs a rebase to get that conftest.py and pass tests.
Technically I think this needs a rebase to get that conftest.py and pass tests.
conftest.py
is in master so when this is merged the master
branch will pass. I've updated the documentation to reflect that the testing results depend on having that file from master
in the correct place.
That's fine. My process is always just to check out the PR and run tests; so for this I'll copy the conftest and run tests if that's the only change that is missing for tests to pass.
Description
This PR opens up a couple of validation limits to remove spurious violations.
For the sun position monitor, the original tolerance of 300 seconds was a little too tight and a few cases of up to 360 seconds occurred. This is related to the difference between predicted eclipse exit times and what the OBC actually did on orbit. This increases the limit to 400 sec.
For off-nominal roll, the error due to sampling the maneuver attitude at only 5-minute bins is a bit larger than was originally assumed. Increasing the tolerance during NMAN from 10 deg to 12 deg removes violations from a 200 day sample.
Interface impacts
None.
Testing
Unit tests
kadi/commands/test/conftest.py
from e99d43e. This file was used in testing and inadvertently left out of the commits.kadi/commands/tests/test_commands.py ........................................................................... [ 34%] kadi/commands/tests/test_states.py ......................x.............................................x.............. [ 72%] ......... [ 76%] kadi/commands/tests/test_validate.py .................... [ 85%] kadi/tests/test_events.py .......... [ 89%] kadi/tests/test_occweb.py ...................... [100%]
========================================= 217 passed, 2 xfailed in 94.04s (0:01:34) ==========================================