Closed taldcroft closed 7 months ago
And I think this one technically need to be either rebased off a rebased validate-finish-line or rebased off master.
And I think this one technically need to be either rebased off a rebased validate-finish-line or rebased off master.
I don't follow.
What environment should I be using to run the unit tests for the record? If it is the updated environment I need this branch rebased to technically get the missing conftest.py in here. If we don't care I can probably run tests against ska3-flight.
And fine, I can use the copied conftest here too for consistency before checking that unit test box.
Description
Fix, document, and test
CommandTable.get_rltt()
andCommandTable.get_schedule_stop_time()
.Fixes #306
This is based off of
validate-finish-line
so all tests pass, but could be rebased and merged into master if need be.Interface impacts
Testing
Unit tests
I confirmed that
get_rltt()
is called many times in the testing so the coverage is good. The new test is the only timeget_scheduled_stop_time
gets covered.Independent check of unit tests by Jean with that conftest.py and with a ska3-masters environment and dev/local versions of chandra_aca, ska_sun, and chandra_maneuver in PYTHONPATH.
Functional tests
No functional testing.