The kadi.commands.core function load_ska_dir() has been superceded by parse_cm.paths.load_dir_from_load_name(). This PR re-implements the kadi load_ska_dir() function as a call to load_dir_from_load_name() and issues a deprecation FutureWarning.
================================================================== 228 passed, 2 xfailed in 98.30s (0:01:38) ===================================================================
Independent check of unit tests by [REVIEWER NAME]
- [ ] [PLATFORM]:
### Functional tests
<!-- Describe and document results of any functional tests, otherwise leave the text below -->
No functional testing.
Description
The
kadi.commands.core
functionload_ska_dir()
has been superceded byparse_cm.paths.load_dir_from_load_name()
. This PR re-implements the kadiload_ska_dir()
function as a call toload_dir_from_load_name()
and issues a deprecationFutureWarning
.Interface impacts
This function is now deprecated and using it will cause unit tests to fail or issue warnings to the console. From https://github.com/search?q=org%3Asot%20ska_load_dir&type=code it seems that only
mica
was using this (fixed in https://github.com/sot/mica/pull/288).Testing
Unit tests
kadi/commands/tests/test_commands.py ...................................................................................... [ 37%] kadi/commands/tests/test_states.py ......................x.............................................x....................... [ 77%] kadi/commands/tests/test_validate.py .................... [ 86%] kadi/tests/test_events.py .......... [ 90%] kadi/tests/test_occweb.py ...................... [100%]
================================================================== 228 passed, 2 xfailed in 98.30s (0:01:38) ===================================================================