sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

WIP : Change time threshold for auto-enable of SPM following eclipse #322

Closed taldcroft closed 4 months ago

taldcroft commented 4 months ago

Description

The matching time threshold of 125 seconds between battery connect time and eclipse entry appears to be too low. Eclipses on 2024:043 and 2024:046 had a delta of 129 to 130 seconds. This results in the sun_pos_mon remaining disabled coming out of eclipse.

This PR changes that value to 150 sec (2.5 minutes). This value may be changed since it causes test fails.

Interface impacts

Testing

Unit tests

Independent check of unit tests by [REVIEWER NAME]

Functional tests

For about 30 seconds I changed the status of the two COMMAND_SW | TLMSID=AOFUNCEN, AOPCADSE=30 commands on day 43 and 46 to be In-work. With that in place I ran kadi validate states locally and confirmed that the sun_pos_mon state matches telemetry.

taldcroft commented 4 months ago

This is not the problem.