Logging for get_cmds should use populated times

sot / kadi

Chandra commands and events

https://sot.github.io/kadi

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

Logging for get_cmds should use populated times #324

Open jeanconn opened 4 months ago

jeanconn commented 4 months ago

I'm seeing

In [5]: obs = kadi.commands.observations.get_observations(obsid=47350)
2024-02-26 12:34:51,965 get_cmds: Getting commands from 2024:057:17:34:51.965 to 2024:057:17:34:51.965 for scenario=None

And that time range isn't helpful. It looks like the logger should log out what time range it is using after None values have been populated.

https://github.com/sot/kadi/blob/5b70b04e42e6255f481620a314ca843286129c2d/kadi/commands/commands_v2.py#L213

jeanconn commented 4 months ago

Granted, it looks like the standard behavior is just to get everything anyway, so a better log message here probably wouldn't help anyway.