sot / kadi

Chandra commands and events
https://sot.github.io/kadi
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

kadi states off_nom_roll validation can fail at far tail sun #329

Closed taldcroft closed 2 months ago

taldcroft commented 2 months ago

I don't understand why off_nom_roll is not tracking better. It seems like the state is not getting recomputed appropriately.

image
jzuhone commented 2 months ago

I have an idea about this that I'll try to check out

taldcroft commented 2 months ago

Sort of answering my question, it appears this attitude is at very far tail sun, pitch about 177.8 deg. The code breaks the state at least once every 10 ksec (or about 3 hours). The states are at around 00:30 and 03:20 and the dots shown above are not state breaks, instead they are breaks put in by the validation plotting.

So it is all basically working, but the math is just not in our favor at far tail sun with off_nom_roll getting squirrely. We could change that 10 ksec to 5 ksec.

taldcroft commented 2 months ago

Closing this unless the validation errors becomes a nuisance. Off nominal roll impacts xija thermal model solar heat via a factor of sin(pitch) , so an error of 5 deg at 177 pitch is negligible.

https://github.com/sot/xija/blob/dac36c2d0c12e5406d4c5bc7498f397e43ed0810/xija/component/heat/solar.py#L64