Closed taldcroft closed 9 years ago
Does this just belong against the web
branch or against both master
and web
? I'm confused by the current branch strategy.
Me too.
Does INSTALLED_APPS need to be a tuple to satisfy Django? If so, should the code add to a list of INSTALLED_APPS and then tuple() it or can it just stay a list?
I don't know about the django requirements, but I think we can just change to INSTALLED_APPS += (app,)
.
I thought it was bad form to modify the tuple even by appending.
Well you cannot modify a tuple (in-place) at all, but I don't think it's bad form to concatenate. That's why they made the +
operator work like it does, so you can concat tuples into another tuple.
I'd propose resolving this issue in #73.
I was wondering about merging #73 before this just to keep the merge simpler, but could obviously go either way.
Whatever works.
Something like this should work:
@jeanconn - we discussed this before, don't remember if it ever got to the point of some code.