search

sot / mica

Microscope on Chandra aspect
https://sot.github.io/mica
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Increase an ASOL quat vs OBC quat test tolerance by 4 arcsecs in roll #253

Closed jeanconn closed 3 years ago

jeanconn commented 3 years ago

Description

Increase an ASOL quat vs OBC quat test tolerance by 4 arcsecs in roll.

The test_get_atts_time code currently runs through a bunch of machinery to compare ASOL quat with OBC quats and asserts they are within some tolerances. It looks like the released ReproV version of an ASOL in this time range has a sample that is 1 arcsec worse in roll. I've increased the tolerance from 51 to 55 in the test in this PR. I could also, for example, set the code to used a fixed version of the ASOLs, but we've recently removed "old" released ASOL files from the archive and we may continue to trim, so I think maybe it makes sense for this code always get the last released ASOL for the comparison.

Testing

No functional testing.

Fixes #

jeanconn commented 3 years ago

As expected this looks to have failed in the overnight dashboard tests so merging should at least help that right away.