Added vectorized versions of some archive.dark_cal functions

javierggt commented 2 years ago

Description

This PR adds vectorized versions of get_dark_cal_id, date_to_dark_id and dark_id_to_date. It also replaces the uses of DateTime by CxoTime inside mica.archive.aca_dark.dark_cal (all other uses of DateTime were left there).

Interface impacts

Everything should be backward compatible. This only enhances the interface, so something like this is possible:

get_dark_cal_id(['2022:100', '2022:105', '2022:127'], 'before')

Testing

Unit tests

I added a test for these vectorized functions.

[x] Mac

Independent check of unit tests by @jeanconn

[x] Linux

Functional tests

No functional testing.

javierggt commented 2 years ago

@jeanconn, sorry for committing stuff after you approved the PR, but I made two more:

check that the date is not earlier than the earliest dark cal, so now the example in #268 gives the following error:
```
ValueError: trying to get last dark cal on 2000:325, which is before the earliest dark cal on 2000:326
```
added another function get_dark_cal_id which returns all dark cals in a dictionary like this:
```
{'2022:104:00:00:00.000': '2022104',
'2022:133:00:00:00.000': '2022133'}
```

jeanconn commented 2 years ago

LGTM. I reran the unit tests and re-approved.

sot / mica