search

sot / mica

Microscope on Chandra aspect
https://sot.github.io/mica
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Handle no-starcat observations better in reports #286

Closed jeanconn closed 10 months ago

jeanconn commented 10 months ago

Description

Tiny changes to handle no starcat observations better in reports. For observations that do not have star catalogs (NMM dwells for IR zone especially) handle the missing star catalog with a handled exception instead of an error and don't try to parse the missing date.

Should stop the "Failed report on 44077" type errors.

Interface impacts

Testing

Tested against a linux ska3-masters environment

Unit tests

Independent check of unit tests by Javier

Functional tests

Updated the report writing unit test to include a recent ER that has no star catalog. With this PR that passes -- fails against master.

javierggt commented 10 months ago

In which loads is this relevant?

jeanconn commented 10 months ago

For the record -- mica isn't really "load" specific? I added one obsid that doesn't have a star catalog (high IR zone) to the test reports (44077). Note that the report writing just works from Linux with Sybase in general.