search

sot / proseco

Probabilistic star evaluation and catalog optimization
https://sot.github.io/proseco
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Improve performance #292

Closed taldcroft closed 5 years ago

taldcroft commented 5 years ago

This includes #291 and substantially improves performance. Mostly (sadly) this is finding ways around the poor performance of astropy Table, but the good news is that this introduces no algorithmic changes.

For the 1468 catalogs in the standard acq regression test set, there are no diffs. In this set the mean time to generate a catalog was reduced from 1.12 sec to 0.51 sec. At this point the time for ACAReviewTable review is probably significant in the overall performance budget.

jeanconn commented 5 years ago

I can't tell from the PR text @taldcroft had benched this on linux, but I can report I am seeing the advertised 2x improvement in aggregate on that platform (as in it just took me half as long to run my separate regression test set on kadi).

taldcroft commented 5 years ago

I never run on linux if I can avoid it. :smile: