Keep box_sizes in the same order as the acq_indices

sot / proseco

Probabilistic star evaluation and catalog optimization

https://sot.github.io/proseco

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Keep box_sizes in the same order as the acq_indices #324

Closed jeanconn closed 4 years ago

jeanconn commented 4 years ago

Description

Keep box_sizes in the same order as the acq_indices

Testing

[x] Passes unit tests on linux (of MacOS, linux, Windows (at least one required))
[x] Functional testing (added new test of the bug as seen in the wild, apparently Add a test for Jean didn't get us all the way there)

Fixes #323

taldcroft commented 4 years ago

@jeanconn - thanks for finding this bug and taking a crack at fixing it. I was pretty concerned about this and spent time to really understand the impact and come up with a more minimal change to fix it.

jeanconn commented 4 years ago

All good. I figured that my example and my fix would at least help illustrate the problem.