Add img_size guide parameter to control guide star image readout size

sot / proseco

Probabilistic star evaluation and catalog optimization

https://sot.github.io/proseco

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Add img_size guide parameter to control guide star image readout size #344

Closed jeanconn closed 4 years ago

jeanconn commented 4 years ago

Description

Add img_size parameter to control box size

Testing

[x] Passes unit tests on Linux
[x] Functional testing (test added)

Fixes #337

Requires:

[ ] API test with Matlab tools

taldcroft commented 4 years ago

@jeanconn - I had a number of suggestions and in the end it was easier to just do them in code. I think this is ready so now you should review.

taldcroft commented 4 years ago

@jskrist - just want to confirm for MATLAB API that you have the machinery to include this optional parameter as necessary.

We are imagining (like the include/exclude interface) that there will be a text option box to manually set the guide star image readout size. It would normally be blank in which case ORviewer does not pass that parameter into the get_aca_catalog call and the Python default of None is used in proseco. But if a value is entered then that gets passed as an integer. Legal values are 4, 6, or 8.

jeanconn commented 4 years ago

I note I just asked the question in https://github.com/sot/sparkles/issues/147 .. should we set the OR default size somewhere in the proseco config?

taldcroft commented 4 years ago

should we set the OR default size somewhere in the proseco config?

This is now coded in the GuideTable.get_img_size() method for any applications to use. Does that work?