search

sot / proseco

Probabilistic star evaluation and catalog optimization
https://sot.github.io/proseco
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

WIP: Save agasc supplement info in meta #354

Closed jeanconn closed 1 year ago

jeanconn commented 3 years ago

Description

Save the agasc supplement info in the meta for a catalog if the supplement data was used.

Testing

jeanconn commented 3 years ago

For this, I didn't add anything fancy, like the checks we have for dark that the date that corresponds the data in the structure is the same as the one that made the catalog ...

taldcroft commented 3 years ago

How might one actually use the value of supp_agasc_version? I can see how the supp_last_updated can (in theory) be used to recover a particular version, but I don't have the imagination to see how the version of the agasc package which was used to update the supplement that time is actionable.

jeanconn commented 3 years ago

I thought it could be useful for the same reason that we put it in the file (which you may also disagree with). For now, for example, we've got a testing file built with a version of agasc before it has been officially promoted. With an eye to real future improvements / development of the code that makes the data, it would be useful to track the version of the agasc module that made the code.

(so you could have a parallel cron task running the testing code with similarly-dated files before final promotion etc).

So I just figured date + version was really what made the data file unique.

But could also cut it for simplicity.

javierggt commented 3 years ago

How might one actually use the value of supp_agasc_version?

I am also not sure we will use it, but supp_agasc_version tells you the version that was actually used to compute the magnitude, so if you ever wanted to compare two catalogs which differ because the star magnitudes were slightly different, you could trace the origin of the discrepancy.

taldcroft commented 3 years ago

I am also not sure we will use it, but supp_agasc_version tells you the version that was actually used to compute the magnitude,

For a particular star mag update (one of the 80000 stars), you have no idea which version of agasc was used to compute that magnitude. The supp_agasc_version just tells you the installed version of agasc for the most recent update to the supplement file, but you have no agasc version that can be tied to a particular mag and mag error. You do of course have the star last update time, which can (with some effort) be tied to the version of agasc. That's what we might do in reality, but the supp_agasc_version being put in the pickle seems not useful.

taldcroft commented 1 year ago

Not likely to ever get promoted.