Adding testing of guide bad pixel margin

sot / proseco

Probabilistic star evaluation and catalog optimization

https://sot.github.io/proseco

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Adding testing of guide bad pixel margin #359

Closed taldcroft closed 3 years ago

taldcroft commented 3 years ago

Description

This started off as adding one pixel of margin to match starcheck and then adding a test, but when I did the testing it seems like there is already a bonus pixel in there somewhere. So this just adds testing.

Testing

[x] Passes unit tests on MacOS, linux, Windows (at least one required)
[n/a] Functional testing

jeanconn commented 3 years ago

I've completely forgotten why we use 4 as the pad for bad pixels and then there's another 1 in here

https://github.com/sot/proseco/blob/bff1f932f21e6cd0e6053a8d4fdd857528cdf364/proseco/guide.py#L1035

Probably just decided to keep tossing compromises at the problem...

taldcroft commented 3 years ago

I was thinking that + 1 was about the width of the pixel itself. Assuming cand['row'] is in 'edge' coordinates, then you need to add 1 to start counting 4 pixels from the top of the pixel.