Remove default n_fid=3 - Githubissues

sot / proseco

Probabilistic star evaluation and catalog optimization

https://sot.github.io/proseco

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Remove default n_fid=3 #360

Closed taldcroft closed 3 years ago

taldcroft commented 3 years ago

Description

The issue with sparkles tests made me think about the default n_fid=3, which is not right in many cases. I think it is better to just force code to be explicit about this.

Testing

[x] Passes unit tests on MacOS
[x] Functional testing: checked with sparkles as well

jeanconn commented 3 years ago

I agree the default was unhelpful.