search

sot / proseco

Probabilistic star evaluation and catalog optimization
https://sot.github.io/proseco
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Set catalog n_guide appropriately in case of mon windows #363

Closed taldcroft closed 3 years ago

taldcroft commented 3 years ago

Description

When getting a catalog via aca = get_aca_catalog(...), the aca.n_guide attribute now reflects the input n_guide minus the number of scheduled monitor windows. This is effectively the number of requested guide stars, accounting for the possibility of monitor stars that are auto-converted from MON to GUI.

To clarify with an example, if n_guide=5 and a monitors arg is provided with the position the target which happens to be a nice 8th mag star in the AGASC suitable for guiding, and the monitor function is AUTO, then aca.n_guide will be 5 and aca.mons will be an empty table.

However, if that target is a 12th mag star which is not suitable for guiding, then aca.n_guide will be 4 and aca.mons will have one entry with a tracking monitor window.

Testing

jskrist commented 3 years ago

possible dumb question: What is the purpose of the "requested number of guide stars" being provided to the algorithm? It seems to be overwritten based on what is actually found. Is it there only for error checking at the end?

jeanconn commented 3 years ago

Not a dumb question. It has been a while but IIRC the number of guide stars requested "of the guide star selection algorithm" is there as an upper limit to help with trivial optimization. If it is an OR and we only need at most 5 guide stars, the search stages and such will stop when we have 5 selectable stars.