Copy back the original kwargs into the monitor catalog call args

sot / proseco

Probabilistic star evaluation and catalog optimization

https://sot.github.io/proseco

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Copy back the original kwargs into the monitor catalog call args #365

Closed jeanconn closed 3 years ago

jeanconn commented 3 years ago

Description

Copy back the original kwargs into the monitor catalog call args

The ACACatalogTable object should have the original arguments and not any arguments that were used just to determine if the monitor window should be a MON or a guide-from-mon, and this change assures that.

Testing

[x] Passes unit tests on linux
[x] Functional testing - new test added in https://github.com/sot/sparkles/pull/156

Fixes #364

jeanconn commented 3 years ago

I don't see any reason that the catalog needs to have the "as solved-for" monitor kwargs instead of the original ones, but if there is another driver for the way this code was working, @taldcroft can speak to it. I also figure he may want to go with a different fix strategy, but this fix can be tested to at least see if I have the scope correctly isolated.

taldcroft commented 3 years ago

Looks good, but just move each of the lines setting the kwargs to be immediately after the line where the catalog is created. That makes the code localized. Also add a comment like # Needed for roll optimization, see #364 in each case.

jeanconn commented 3 years ago

I confirm this was re-tested with the new sparkles test.