Closed taldcroft closed 2 years ago
@jeanconn - ready for final review
@javierggt - can you Approve the PR?
yes, I was going over the output of the notebook that was running. My plots look slightly different, but I am guessing that's because I have not updated ska data in a while.
Description
Per discussion at SS&AWG on 2022-Apr-27 (see the presentation there for full details), this adds two new parameters to the base
ACACatalogTable
and theget_aca_catalog
function to allow specifying the parameters of the bonus stars.Requires:
Interface impacts
Adds
dyn_bgd_n_faint
anddyn_bgd_dt_ccd
arguments toget_aca_catalog
. The default settings (in particulardyn_bgd_n_faint = 0
) have behavior that is identical to current flight star selection.Testing
Unit tests using above-mentioned branches
Independent check of unit tests by Javier
Functional tests