sot / proseco

Probabilistic star evaluation and catalog optimization
https://sot.github.io/proseco
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Allow bonus faint guide stars for dyn bgd enabled #372

Closed taldcroft closed 2 years ago

taldcroft commented 2 years ago

Description

Per discussion at SS&AWG on 2022-Apr-27 (see the presentation there for full details), this adds two new parameters to the base ACACatalogTable and the get_aca_catalog function to allow specifying the parameters of the bonus stars.

Requires:

Interface impacts

Adds dyn_bgd_n_faint and dyn_bgd_dt_ccd arguments to get_aca_catalog. The default settings (in particular dyn_bgd_n_faint = 0) have behavior that is identical to current flight star selection.

Testing

Unit tests using above-mentioned branches

Independent check of unit tests by Javier

Functional tests

taldcroft commented 2 years ago

@jeanconn - ready for final review

taldcroft commented 2 years ago

@javierggt - can you Approve the PR?

javierggt commented 2 years ago

yes, I was going over the output of the notebook that was running. My plots look slightly different, but I am guessing that's because I have not updated ska data in a while.