Adjust acq selection to limit search hits to < 50

taldcroft commented 2 years ago

Description

This implements the constraint imposed by the contour plot in https://occweb.cfa.harvard.edu/twiki/bin/view/Aspect/PeaMaxMagTesting.

Interface impacts

No API change in get_aca_catalog or other functional interfaces.

The only update of note is that setting the environment variable PROSECO_IGNORE_MAXMAGS_CONSTRAINTS to any value will cause proseco to ignore the search hits limit in this PR. This is included for testing.

Testing

Unit tests

[x] Mac

Independent check of unit tests by [REVIEWER NAME]

[ ] [PLATFORM]:

Functional tests

[x] Reselect catalogs for 4 recent weekly loads at CCD temperature of -4.0 C and review diffs. This notebook is included in this PR. See validate-maxmags-recent-loads.ipynb

jeanconn commented 2 years ago

I added related issue https://github.com/sot/sparkles/issues/176 which will need the maxmag data.

taldcroft commented 2 years ago

Thanks for the review @jeanconn !

jeanconn commented 2 years ago

I note with this merged that we're seeing a "fail" in ska_testr sparkles just based on the new warning:

  /export/jgonzale/github-workflows/miniconda3/envs/ska3-masters/lib/python3.8/site-packages/proseco/acq.py:70: UserWarning: Clipping t_ccd=10 to 0.0 for interpolating MAXMAGs table
    warnings.warn(f"Clipping {t_ccd=} to 0.0 for interpolating MAXMAGs table")

Since we plan a release of sparkles to go with this anyway, this is benign.

sot / proseco