search

sot / proseco

Probabilistic star evaluation and catalog optimization
https://sot.github.io/proseco
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Add test of optional ACA limits #385

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

This adds a unit test that verifiers the functionality in #384.

As a small out-of-scope change, move to matplotlib.pyplot.switch_backend to avoid the linting problem with imports after code.

Interface impacts

None.

Testing

Unit tests

Independent check of unit tests by Jean

Functional tests

No functional testing.

taldcroft commented 1 year ago

@jeanconn - please approve if you are good with this.

jeanconn commented 1 year ago

I eye-balled the new git and model fetching and manipulation but haven't had a chance to do review on this yet.

taldcroft commented 1 year ago

Ah OK, I misinterpreted the scope of "This seems fine". No problem.

taldcroft commented 1 year ago

should proseco also be using @chandra_models.chandra_models_cache to get the model?

Good point. I think something like this can work and be a good thing. Next PR... #386