sot / proseco

Probabilistic star evaluation and catalog optimization
https://sot.github.io/proseco
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Exclude COLOR1=0.7 stars from guide selection #401

Closed jeanconn closed 1 month ago

jeanconn commented 1 month ago

Description

Exclude COLOR1=0.7 stars from guide selection.

We decided to not use COLOR1=0.7 stars for guide at the 2024x09x11 SS&AWG meeting. We implemented that immediately via adding those stars to the 'bad' table in the supplement, but the idea here is that it is simpler to just add that to the mask and then remove the stars from bad table.

Interface impacts

Testing

Unit tests

proseco/tests/test_acq.py ..................................... [ 22%] proseco/tests/test_catalog.py .......................................... [ 47%] proseco/tests/test_core.py ........................... [ 63%] proseco/tests/test_diff.py ...... [ 66%] proseco/tests/test_fid.py ............... [ 75%] proseco/tests/test_guide.py ..................................... [ 97%] proseco/tests/test_mon_full_cat.py .... [100%]

===================================================== 168 passed in 24.45s



Independent check of unit tests by [REVIEWER NAME]
- [ ] [PLATFORM]:

### Functional tests
<!-- Describe and document results of any functional tests, otherwise leave the text below -->
I added a new unit test that fails if the COLOR1 != 0.7 filter is not applied.