search

sot / ska_helpers

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

when running testr, avoid emitting this warning #10

Closed javierggt closed 4 years ago

javierggt commented 4 years ago

Description

This PR introduces changes to silence a warning ska_helpers.version emits whenever it can't figure out the version. In particular, this warning is emitted during testr runs. The resulting warning is then misinterpreted as a failure.

Strictly speaking, the warning is correct, because pytest seems to be importing the module incorrectly. It does that while climbing the directory tree until it finds the root of the package. In the end, it does the right import and everything is ok. At this point the warning was emitted already.

These are possible solutions:

  1. silence the warning when a TESTR_ variable is in os.environ.
  2. set a specific environment variable to silence this warning.
  3. Modify the log parsing tests to correctly interpret and skip this warning.
  4. have ska_helpers.version climb the directory tree to find its root.

This PR implements the first option. Second could also be. I would hesitate to implement the fourth.

Testing

Fixes #

javierggt commented 4 years ago

Perhaps we should approve this before closing sot/skare3/pull/342