sot / sparkles

ACA review of star catalogs from proseco
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Roll options range can span 360 deg #115

Open taldcroft opened 5 years ago

taldcroft commented 5 years ago

The roll options report for obs 48160 shows a problem with getting roll_min, roll_nom, and roll_max on the same page:

Roll options report (roll_min=0.63 roll_nom=355.77 roll_max=375.77)

I thought this was handling this corner case, but clearly not. Note that the code thinks the roll_nom is outside the roll_min to roll_max range.

Here are the 48160 params:

In [18]: acas[48160].meta['call_args']
Out[18]: 
{'att': <Quat q1=0.17951289 q2=0.09414063 q3=-0.85353384 q4=0.47999234>,
 'date': '2019:142:14:22:30.300',
 'detector': 'HRC-S',
 'dither_acq': (7.9992, 7.9992),
 'dither_guide': (7.9992, 7.9992),
 'focus_offset': 0.0,
 'man_angle': 88.11278890416182,
 'n_acq': 8,
 'n_fid': 0,
 'n_guide': 8,
 'obsid': 48160.0,
 'sim_offset': 0.0,
 't_ccd_acq': -9.699565253388428,
 't_ccd_guide': -9.552856798812403}