sot / sparkles

ACA review of star catalogs from proseco
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Add module to find ER catalog #161

Closed taldcroft closed 3 years ago

taldcroft commented 3 years ago

Description

Add module to find ER catalog.

This requires https://github.com/sot/Quaternion/pull/39.

Testing

Fixes https://github.com/sot/ska-projects/issues/107

taldcroft commented 3 years ago

@jeanconn - I'd like to get this in soon so please have a look. It will be better to have it in the release and we can test or develop against it. We can consider this to be experimental for the moment and it's certainly possible there will be API changes when it gets connected with ORviewer.

jeanconn commented 3 years ago

When you say "the release" do you mean the flight one for today?

On Wed, Sep 22, 2021, 7:05 AM Tom Aldcroft @.***> wrote:

@jeanconn https://github.com/jeanconn - I'd like to get this in soon so please have a look. It will be better to have it in the release and we can test or develop against it. We can consider this to be experimental for the moment and it's certainly possible there will be API changes when it gets connected with ORviewer.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sot/sparkles/pull/161#issuecomment-924825571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGBHVBIBZPFOQUKXLAIQRLUDG2BBANCNFSM5CZ67HGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

taldcroft commented 3 years ago

No, I just meant the flight release so it isn't just hanging here as a PR for too long. So whenever the next available release goes out.

jeanconn commented 3 years ago

Right, the next one is just technically today. But I would like a little more time to review this.

taldcroft commented 3 years ago

I'm using the Polish next, which is the one after the US English next one.