The values come from pitch_roll_2021_spm_phase3.xlsx sent 16-Dec-2021.
That file has signed/positive and negative roll ranges but all the magnitudes
are the same for each sign for each row, so reduced the table to the
unsigned version.
Testing
[x] Passes unit tests on MacOS, linux, Windows (at least one required)
[x] Functional testing
It isn't functional testing, but as a sanity check I just plotted the rolldev in the old and new files and confirmed for myself they are different
and then for functional testing confirmed that the allowed_rolldev function works and gets different answers around the "throat" at 135:
Flight:
In [1]: from sparkles.roll_optimize import allowed_rolldev
In [2]: allowed_rolldev(135)
Out[2]: 18.7487718079
In [3]: allowed_rolldev(138)
Out[3]: 7.334
PR
In [1]: from sparkles.roll_optimize import allowed_rolldev
In [2]: allowed_rolldev(135)
Out[2]: 13.979
In [3]: allowed_rolldev(138)
Out[3]: 14.516
jeanconn
commented
2 years ago
Description
Update pitch/roll table
The values come from pitch_roll_2021_spm_phase3.xlsx sent 16-Dec-2021. That file has signed/positive and negative roll ranges but all the magnitudes are the same for each sign for each row, so reduced the table to the unsigned version.
Testing
It isn't functional testing, but as a sanity check I just plotted the rolldev in the old and new files and confirmed for myself they are different
and then for functional testing confirmed that the allowed_rolldev function works and gets different answers around the "throat" at 135:
Flight:
PR
Fixes https://github.com/sot/Ska.Sun/issues/18 (basically)