Closed taldcroft closed 2 years ago
Should it also just get the target name if available in get_yoshi_params_from_ocat?
Should it also just get the target name if available in get_yoshi_params_from_ocat?
Yes, done.
@jeanconn - I fixed the issues you noted.
Thanks. I also ran this on the somewhat stressing case of obsid 17892 which has no target name. Did not cause any errors or issues with output. I note that in general that convert_yoshi_to_proseco_params doesn't behave well for old observations (< 2012) because chandra_aca.drift complains that the dynamic stuff doesn't work for historical observations that old. But that's not an issue for this code and not an issue for the way we are likely to use sparkles.
Description
This PR has a few small updates which facilitate the feasibility studies of cycle 24 proposed targets.
max_roll_dev
is really the max roll deviation when supplied.roll_dev
parameter that was basically redundant.run_one_yoshi
andconvert_yoshi_to_proseco_params
. For the cycle 24 studies this allows passingtarget_name
directly.Interface impacts
roll_dev
arg toAcaReviewTable.get_roll_intervals()
method is now deprecated and will raise aFutureWarning
if supplied.Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
Works with https://gist.github.com/taldcroft/92d6d92ed80316a9a66dffbf9379eb52.