The previous implementation had a bug where the t_ccds_bonus property was ordered with respect to sorted(mags) instead of mags. In most cases the guide star mags are roughly sorted in ascending order, but this is not always the case.
An unrelated update was applied to the pre-commit config to get that working.
This also includes the formatting fix in #191.
Interface impacts
Adds a new function get_t_ccds_bonus to the top-level public interface. This can be used in starcheck.
Testing
Added new unit tests that give better coverage of this functionality.
Description
The previous implementation had a bug where the
t_ccds_bonus
property was ordered with respect tosorted(mags)
instead ofmags
. In most cases the guide star mags are roughly sorted in ascending order, but this is not always the case.An unrelated update was applied to the pre-commit config to get that working.
This also includes the formatting fix in #191.
Interface impacts
Adds a new function
get_t_ccds_bonus
to the top-level public interface. This can be used in starcheck.Testing
Added new unit tests that give better coverage of this functionality.
Unit tests
Independent check of unit tests by Jean
Functional tests
Unit tests added as functional tests.