sot / sparkles

ACA review of star catalogs from proseco
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Fix issue computing t_ccds_bonus and refactor into function #192

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

The previous implementation had a bug where the t_ccds_bonus property was ordered with respect to sorted(mags) instead of mags. In most cases the guide star mags are roughly sorted in ascending order, but this is not always the case.

An unrelated update was applied to the pre-commit config to get that working.

This also includes the formatting fix in #191.

Interface impacts

Adds a new function get_t_ccds_bonus to the top-level public interface. This can be used in starcheck.

Testing

Added new unit tests that give better coverage of this functionality.

Unit tests

Independent check of unit tests by Jean

Functional tests

Unit tests added as functional tests.