Closed jeanconn closed 10 months ago
I would have thought we just use the original fast sun positions via a fast_sun_position_method
fixture that gets applied to each failing test. This is useful as a regression test to make sure that all the other coupled changes (chandra_maneuver, chandra_aca etc) don't introduce a change here.
Though it is probably worth having at least one test that uses the default sun position and then the fast method. The final test_get_params()
looks like a good candidate to basically duplicate into test_get_params_sun_position_default
and test_get_params_sun_position_fast
.
I figured that unless you plan to update the application (sparkles) default to use position_fast (a possibility but one we hadn't discussed) that this was a just one-and-done change to the regress data. And having the changes as diffs in github was useful. If you want to keep the position_fast test data as a different functional test I'm not sure I understand the value of that long term.
Description
Update test expected values for small roll changes caused by change to default method for position in ska_sun.
Interface impacts
Testing
Unit tests
Functional tests
No functional testing.