This updates the tests of find_er_attitude to reflect the new yaw sign convention introduced in https://github.com/sot/ska_sun/pull/37. All the dyaw values are just flipped in sign but there are no other functional changes.
The test import of Ska.Sun was changed to ska_sun.
The dyaw column in the att_opts table will be flipped in sign from the previous results. This is a good thing since it now reflects directly what we would tell mission planning and engineers for a yaw bias maneuver. I.e. dyaw = +5 deg would imply creating a command load using a positive yaw bias rate input.
=========================================================== 103 passed in 43.57s
(ska3) flame:sparkles jean$ python -c "import ska_sun; print(ska_sun.version)"
3.13.1.dev2+g2ec26c1 # I tested against this from the merged ska_sun pr in the masters channel
### Functional tests
<!-- Describe and document results of any functional tests, otherwise leave the text below -->
No functional testing.
Description
This updates the tests of
find_er_attitudeto reflect the new yaw sign convention introduced in https://github.com/sot/ska_sun/pull/37. All thedyawvalues are just flipped in sign but there are no other functional changes.The test import of
Ska.Sunwas changed toska_sun.Requires
Interface impacts
The
dyawcolumn in theatt_optstable will be flipped in sign from the previous results. This is a good thing since it now reflects directly what we would tell mission planning and engineers for a yaw bias maneuver. I.e.dyaw = +5 degwould imply creating a command load using a positive yaw bias rate input.Testing
Unit tests
sparkles/tests/test_checks.py ............................................................................ [ 73%] sparkles/tests/test_find_er_catalog.py ..... [ 78%] sparkles/tests/test_review.py .................. [ 96%] sparkles/tests/test_yoshi.py .... [100%]
===================================================== 103 passed in 34.73s ======================================================
(ska3) flame:sparkles jean$ git rev-parse HEAD 2a96ec2c9d248f81cb06ebe425caeae95804723f (ska3) flame:sparkles jean$ pytest =========================================================== test session starts ============================================================ platform darwin -- Python 3.10.8, pytest-7.2.1, pluggy-1.0.0 rootdir: /Users/jean/git, configfile: pytest.ini plugins: timeout-2.1.0, anyio-3.6.2 collected 103 items
sparkles/tests/test_checks.py ............................................................................ [ 73%] sparkles/tests/test_find_er_catalog.py ..... [ 78%] sparkles/tests/test_review.py .................. [ 96%] sparkles/tests/test_yoshi.py .... [100%]
=========================================================== 103 passed in 43.57s (ska3) flame:sparkles jean$ python -c "import ska_sun; print(ska_sun.version)" 3.13.1.dev2+g2ec26c1 # I tested against this from the merged ska_sun pr in the masters channel