set obsid report dir with a name consistent with proseco

[javierggt]

Description

This is a trivial change with no consequence in the usual cases. It only affected me because I ran sparkles.run_aca_review giving it a catalog with obsid=0. This resulted in some files saved into a directory called obs0 and others in a directory called obs00000 (because proseco does it this way and this way). This PR fixes that inconsistency.

Interface impacts

Testing

Unit tests

• [x] Mac

(ska3-flight-2024.9rc1) ~/SAO/git/sparkles obsid_dir $ pytest sparkles
============================================================= test session starts =============================================================
platform darwin -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /Users/javierg/SAO/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 103 items                                                                                                                           

sparkles/tests/test_checks.py ............................................................................                              [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                            [ 78%]
sparkles/tests/test_review.py ..................                                                                                        [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                       [100%]

============================================================== warnings summary ===============================================================
sparkles/sparkles/tests/test_checks.py: 86 warnings
sparkles/sparkles/tests/test_find_er_catalog.py: 16 warnings
sparkles/sparkles/tests/test_review.py: 86 warnings
sparkles/sparkles/tests/test_yoshi.py: 2 warnings
  /Users/javierg/miniforge3/envs/ska3-flight-2024.9rc1/lib/python3.11/site-packages/tables/node.py:251: DeprecationWarning: `alltrue` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `all` instead.
    self._v_objectid = self._g_open()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
===================================================== 103 passed, 190 warnings in 22.98s ======================================================
(ska3-flight-2024.9rc1) ~/SAO/git/sparkles obsid_dir $ git rev-parse HEAD
1c32959e979c611c5360feed525cb80cf1a331f0

Independent check of unit tests by @taldcroft

• [x] Mac

Functional tests

I functionally tested this with aperoll (by default obsid=0), running sparkles, and checking the acq and guide reports.

TA: same functional test, also pass.

[taldcroft]

Looks OK, needs documentation of unit and functional testing.

[javierggt]

Looks OK, needs documentation of unit and functional testing.

Done.