search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Apply effective temperature "penalty" #308

Closed jeanconn closed 5 years ago

jeanconn commented 5 years ago

Since the starcheck calls to the proseco stuff are constructing an acq catalog from the commanded catalog and then getting calc_p_safe, I think the the proseco get_effective_t_ccd method is never called.

We probably want to use the penalty on the starcheck side too (for the time being, until sparkles checks are properly integrated).

taldcroft commented 5 years ago

I think this should be fairly trivial, namely just replace the call to get_acq_catalog to get_aca_catalog, with a few tweaks to the kwargs. The use aca.acqs instead of acq_cat.

Probably just need to add n_guide=0, n_fid=0. You don't have to change the include_* kwargs, but it might make the code more clear to use include_ids_acq (etc).

Going through the cat_aca_catalog function will engage the effective temperature machinery.

taldcroft commented 5 years ago

Which points to a general API recommendation of always using get_aca_catalog for making catalogs, even if only an acq catalog is desired.

jeanconn commented 5 years ago

Right, I think we had a bunch of proseco API changes after I figured out something for starcheck and I wasn't sure if this transition was worth it until we had include_ids_fids.

jeanconn commented 5 years ago

Closed by #309