sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

In case of mismatch between kadi dither and History starcheck may just fail #346

Closed jeanconn closed 2 years ago

jeanconn commented 4 years ago

Copying the comment in from

https://github.com/sot/starcheck/pull/304#issuecomment-528945415

It looks like for SEP0619B, we ran into a condition where the kadi commanded states dither state didn't match the History

Dither status in kadi commands does not match DITHER history

And the dither amplitudes were left undefined when passed to proseco to determine P2 values causing a TypeError

 at ./starcheck/src/starcheck.pl line 45.
    main::__ANON__("TypeError: unsupported operand type(s) for +: 'NoneType' and "...) called at (eval 80) line 3
    Ska::Starcheck::Obsid::proseco_probs("__main__", "proseco_probs", HASH(0x4888800)) called at starcheck/src/lib/Ska/Starcheck/Obsid.pm line 2997
    Ska::Starcheck::Obsid::set_proseco_probs_and_check_P2(Ska::Starcheck::Obsid=HASH(0x6de59d0)) called at ./starcheck/src/starcheck.pl line 690

Whichever way we decide to go, we should probably configure so either History or kadi commands "wins" and makes some kind of dither states for starcheck to proceed (with big red warnings or whatever).

This was also a problem in my first runs of MAY2620A, without a correct dither disable in cmd_states cmds (but dither disabled in History).